Speedup RNG copy in non-mutable RVs #1721
Open
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Nov 16, 2025
Member
|
Also make use of the new helper here: |
ricardoV94
changed the title
Contributor
Author
|
@ricardoV94 Thank you for the checks. I have made the corrections |
ricardoV94
reviewed
Nov 17, 2025
tests/tensor/random/test_utils.py
Outdated
Comment on lines
361
to
369
| @pytest.mark.performance | ||
| def test_custom_rng_deepcopy_faster_than_deepcopy(): | ||
| rng = np.random.default_rng() | ||
|
|
||
| t_dp = timeit.timeit(lambda: deepcopy(rng), number=2000) | ||
| t_fc = timeit.timeit(lambda: custom_rng_deepcopy(rng), number=2000) | ||
|
|
||
| # Fast copy should be at least 20% faster | ||
| assert t_fc < t_dp * 0.8 |
Member
There was a problem hiding this comment.
No need, and we have a different framework for benchmarking
Contributor
Author
There was a problem hiding this comment.
Done! I didn't know about the benchmarking framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how RandomVariable copies RNG state when inplace=False.
Related Issue
Checklist
Type of change
@ricardoV94 I think this closes the #1708 using the code you provided, I just added some tests